Fix to interpret logger channel names as lowercase #4848
Conversation
Co-authored-by: Felanbird <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Thanks for your contribution!
In our changelog style, the number behind the changelog entry should be the number of the PR rather than the issue, since we think it gives a bit more context for the whole fix process. Other than that, this works as expected and is the correct solution to this 👍
Only other feedback I have for future contributions is that it's best to use a branch other than master or main or mainline for your PRs, make a specific change branch like fix/logger-lowercase, that way it'll be easier to manage your workflow if you have multiple PRs active to the same repo, and it'll be easier on my end since your branch name doesn't conflict with our main branch name
|
As a first-time contributor, you can now add yourself to the contributors list that's shown inside the About page in Chatterino. If you want this, you can open a new PR where you modify the |
Description
Fixes the issue (#4835) where logging channels with capitalization wouldn't work, by making channel names lowercase.
I tested the original exe file without my changes and then tested an exe file with my changes and it works.